paleolimbot commented on code in PR #46275:
URL: https://github.com/apache/arrow/pull/46275#discussion_r2069376548
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1250,8 +1250,11 @@ class TypedColumnWriterImpl : public ColumnWriterImpl,
page_statistics_ = MakeStatistics<ParquetType>(descr_, allocator_);
chunk_statistics_ = MakeStatistics<ParquetType>(descr_, allocator_);
}
+
if (descr_->logical_type() != nullptr &&
descr_->logical_type()->is_geometry()) {
chunk_geospatial_statistics_ =
std::make_shared<geospatial::GeoStatistics>();
+ page_statistics_ = MakeStatistics<ParquetType>(descr_, allocator_);
+ chunk_statistics_ = MakeStatistics<ParquetType>(descr_, allocator_);
Review Comment:
The actual version of this should maybe modify the `if (SortOrder::UNKNOWN
!= descr_->sort_order()) {` check just above. Perhaps there needs to be a
`descr_->can_write_statistics()` to separate the sortedness from whether or not
we can write anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
