paleolimbot commented on code in PR #46275:
URL: https://github.com/apache/arrow/pull/46275#discussion_r2069378772
##########
cpp/src/parquet/metadata.cc:
##########
@@ -307,8 +307,10 @@ class ColumnChunkMetaData::ColumnChunkMetaDataImpl {
DCHECK(writer_version_ != nullptr);
// If the column statistics don't exist or column sort order is unknown
// we cannot use the column stats
+ bool is_geometry =
+ descr_->logical_type() != nullptr &&
descr_->logical_type()->is_geometry();
if (!column_metadata_->__isset.statistics ||
- descr_->sort_order() == SortOrder::UNKNOWN) {
+ (descr_->sort_order() == SortOrder::UNKNOWN && !is_geometry)) {
Review Comment:
Again, maybe we need a `descr_->can_read_statistics`? There's a
`HasCorrectStatistics()`, too, and maybe the check needs to be there. I wonder
whether the types currently marked as unsorted had null counts written reliably
by other implementations or whether we have to ignore those?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
