thisisnic commented on code in PR #44971:
URL: https://github.com/apache/arrow/pull/44971#discussion_r2070257320
##########
r/tests/testthat/helper-skip.R:
##########
@@ -124,6 +124,18 @@ skip_on_python_older_than <- function(python_version) {
}
}
+skip_if_arrow_version_less_than <- function(version, msg) {
+ if (arrow::arrow_info()$version < numeric_version(version)) {
+ skip(msg)
+ }
+}
+
+skip_if_arrow_version_equals <- function(version, msg) {
+ if (arrow::arrow_info()$version == numeric_version(version)) {
+ skip(msg)
+ }
+}
+
Review Comment:
```suggestion
skip_if_arrow_version_less_than <- function(version, msg) {
if (arrow_cpp_version() < numeric_version(version)) {
skip(msg)
}
}
skip_if_arrow_version_equals <- function(version, msg) {
if (arrow_cpp_version() == numeric_version(version)) {
skip(msg)
}
}
arrow_cpp_version <- function(){
numeric_version(gsub("-SNAPSHOT", "",
arrow::arrow_info()$build_info["cpp_version"]))
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
