jonkeane commented on code in PR #44971:
URL: https://github.com/apache/arrow/pull/44971#discussion_r2071567041
##########
r/tests/testthat/test-dplyr-funcs-math.R:
##########
@@ -399,3 +493,19 @@ test_that("sqrt()", {
df
)
})
+
+test_that("expm1()", {
+ skip_if_arrow_version_less_than("18.1.0.9000", "`expm1()` not available
until version 19.")
Review Comment:
We do test across versions of libarrow (maybe that failed when you were
looking at this? It doesn't look like it from the commit history, but maybe I'm
missing it), though looking at the discussion in
https://github.com/apache/arrow/issues/43623 it looks like no one is interested
in maintaining + teaching folks about libarrow cross compatibility such that
it's worth it to keep that job + the maintenance cost of that.
I'll try removing / reverting in my other PR and see though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
