toddmeng-db commented on code in PR #2762:
URL: https://github.com/apache/arrow-adbc/pull/2762#discussion_r2070905326
##########
csharp/src/Drivers/Apache/Spark/SparkParameters.cs:
##########
@@ -27,9 +27,13 @@ public class SparkParameters
public const string Path = "adbc.spark.path";
public const string Token = "adbc.spark.token";
- // access_token is required when authType is oauth
+ // access_token is required when authType is oauth and authFlow is 0
public const string AccessToken = "adbc.spark.access_token";
public const string AuthType = "adbc.spark.auth_type";
+ public const string AuthFlow = "adbc.spark.oauth.auth_flow";
Review Comment:
any hesitation for using string for authflow? Just did for consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
