toddmeng-db commented on code in PR #2762:
URL: https://github.com/apache/arrow-adbc/pull/2762#discussion_r2073822411
##########
csharp/src/Drivers/Apache/Spark/SparkHttpConnection.cs:
##########
@@ -51,10 +51,15 @@ protected override void ValidateAuthentication()
Properties.TryGetValue(AdbcOptions.Password, out string? password);
Properties.TryGetValue(SparkParameters.AuthType, out string?
authType);
Properties.TryGetValue(SparkParameters.AccessToken, out string?
access_token);
+ Properties.TryGetValue(SparkParameters.AuthFlow, out string?
authFlow);
Review Comment:
Thanks, I'll move the values to an enum since it's a bit cleaner. To the
second point, I'll move it to DatabricksParameter for now, since it seems like
not all Spark deployments will support OAuth natively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
