khwilson commented on code in PR #44184:
URL: https://github.com/apache/arrow/pull/44184#discussion_r2074659482
##########
cpp/src/arrow/compute/kernels/aggregate_basic.cc:
##########
@@ -365,11 +365,16 @@ struct ProductImpl : public ScalarAggregator {
}
Status Finalize(KernelContext*, Datum* out) override {
+ std::shared_ptr<DataType> out_type_ = this->out_type;
+ if (is_decimal(this->out_type->id())) {
+ ARROW_ASSIGN_OR_RAISE(out_type_,
WidenDecimalToMaxPrecision(this->out_type));
+ }
+
Review Comment:
The link you have is to a different commit, I believe. If you look at those
lines in this PR they do change the type at resolution time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
