khwilson commented on code in PR #44184:
URL: https://github.com/apache/arrow/pull/44184#discussion_r2074666687
##########
cpp/src/arrow/compute/kernels/aggregate_basic.cc:
##########
@@ -365,11 +365,16 @@ struct ProductImpl : public ScalarAggregator {
}
Status Finalize(KernelContext*, Datum* out) override {
+ std::shared_ptr<DataType> out_type_ = this->out_type;
+ if (is_decimal(this->out_type->id())) {
+ ARROW_ASSIGN_OR_RAISE(out_type_,
WidenDecimalToMaxPrecision(this->out_type));
+ }
+
Review Comment:
I can't remember exactly why I had to do this. I believe it's related to how
the `Visit` function gets called for `SumLikeImpl`. Once the rebase is done I
can take a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
