nealrichardson commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r607363061
##########
File path: r/tests/testthat/test-feather.R
##########
@@ -196,3 +196,17 @@ test_that("Character vectors > 2GB can write to feather", {
})
unlink(feather_file)
+
+ft_file <- test_path("golden-files/data-arrow_2.0.0_lz4.feather")
+
+test_that("Error messages are shown when the compression algorithm lz4 is not
found", {
+ if (codec_is_available("lz4")) {
+ d <- read_feather(ft_file)
+ expect_is(d, "data.frame")
+ } else {
+ expect_error(
+ read_feather(ft_file),
+ "Unsupported compressed format"
Review comment:
You may want to assert the whole message here since you're doing some
rather complex string manipulation to assemble it.
##########
File path: r/tests/testthat/test-feather.R
##########
@@ -196,3 +196,17 @@ test_that("Character vectors > 2GB can write to feather", {
})
unlink(feather_file)
+
+ft_file <- test_path("golden-files/data-arrow_2.0.0_lz4.feather")
+
Review comment:
Not duplication, your code changes in parquet.R are not tested without
them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
