pachamaltese commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r607407735
##########
File path: r/R/feather.R
##########
@@ -147,14 +147,17 @@ read_feather <- function(file, col_select = NULL,
as_data_frame = TRUE, ...) {
file <- make_readable_file(file)
on.exit(file$close())
}
- reader <- FeatherReader$create(file, ...)
+ reader <- FeatherReader$create(file)
Review comment:
for example, from https://github.com/apache/arrow/pull/9756/files
I still could still pass a mmap = TRUE to FileCreate from read_feather, so
the ... is probably valuable in this context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
