albertlockett commented on code in PR #7446:
URL: https://github.com/apache/arrow-rs/pull/7446#discussion_r2080219726
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -1911,6 +1915,50 @@ mod tests {
roundtrip(batch, Some(SMALL_SIZE / 2));
}
+ #[test]
+ fn test_fixed_size_binary_in_dict() {
+ fn test_fixed_size_binary_in_dict_inner<K>()
+ where
+ K: ArrowDictionaryKeyType,
+ K::Native: FromPrimitive + ToPrimitive + TryFrom<u8>,
+ <<K as arrow_array::ArrowPrimitiveType>::Native as
TryFrom<u8>>::Error: std::fmt::Debug,
+ {
+ let field = Field::new(
+ "a",
+ DataType::Dictionary(
+ Box::new(K::DATA_TYPE),
+ Box::new(DataType::FixedSizeBinary(4)),
+ ),
+ false,
+ );
+ let schema = Schema::new(vec![field]);
+
+ let keys: Vec<K::Native> = vec![
+ K::Native::try_from(0u8).unwrap(),
+ K::Native::try_from(0u8).unwrap(),
+ K::Native::try_from(1u8).unwrap(),
+ ];
+ let keys = PrimitiveArray::<K>::from_iter_values(keys);
+ let values = FixedSizeBinaryArray::try_from_iter(
+ vec![vec![0, 0, 0, 0], vec![1, 1, 1, 1]].into_iter(),
+ )
+ .unwrap();
+
+ let data = DictionaryArray::<K>::new(keys, Arc::new(values));
+ let batch = RecordBatch::try_new(Arc::new(schema),
vec![Arc::new(data)]).unwrap();
+ roundtrip(batch, None);
Review Comment:
yes thanks for checking @alamb.
Sorry, I should have replied earlier to your other comment about this and
confirmed that we already had the roundtrip test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
