zhuqi-lucas commented on PR #7454:
URL: https://github.com/apache/arrow-rs/pull/7454#issuecomment-2869786526

   > I completed another benchmark run now and got these results
   > 
   > The major difference is slow downs in the async reader for Q38-Q40:
   > 
   > ```
   > arrow_reader_clickbench/async/Q37    1.02    104.2±0.47ms        ? ?/sec   
 1.00    101.6±0.42ms        ? ?/sec
   > arrow_reader_clickbench/async/Q38    1.00     41.6±0.33ms        ? ?/sec   
 1.23     51.1±0.42ms        ? ?/sec
   > arrow_reader_clickbench/async/Q39    1.00     50.3±0.30ms        ? ?/sec   
 1.32     66.2±0.42ms        ? ?/sec
   > arrow_reader_clickbench/async/Q40    1.00     55.3±0.60ms        ? ?/sec   
 1.22     67.4±0.60ms        ? ?/sec
   > arrow_reader_clickbench/async/Q41    1.00     42.1±0.32ms        ? ?/sec   
 1.12     47.3±0.56ms        ? ?/sec
   > ```
   > 
   > ```
   > + critcmp main unified_select
   > group                                main                                  
 unified_select
   > -----                                ----                                  
 --------------
   > arrow_reader_clickbench/async/Q1     1.00      3.7±0.02ms        ? ?/sec   
 1.03      3.8±0.01ms        ? ?/sec
   > arrow_reader_clickbench/async/Q10    1.00     14.2±0.16ms        ? ?/sec   
 1.01     14.3±0.21ms        ? ?/sec
   > arrow_reader_clickbench/async/Q11    1.00     16.1±0.13ms        ? ?/sec   
 1.04     16.7±0.20ms        ? ?/sec
   > arrow_reader_clickbench/async/Q12    1.43     39.9±0.42ms        ? ?/sec   
 1.00     27.9±0.31ms        ? ?/sec
   > arrow_reader_clickbench/async/Q13    1.55     53.4±0.40ms        ? ?/sec   
 1.00     34.4±0.79ms        ? ?/sec
   > arrow_reader_clickbench/async/Q14    1.61     51.1±0.38ms        ? ?/sec   
 1.00     31.8±0.38ms        ? ?/sec
   > arrow_reader_clickbench/async/Q19    1.00      5.0±0.07ms        ? ?/sec   
 1.06      5.3±0.07ms        ? ?/sec
   > arrow_reader_clickbench/async/Q20    1.39    163.8±0.69ms        ? ?/sec   
 1.00    117.8±0.75ms        ? ?/sec
   > arrow_reader_clickbench/async/Q21    1.60    211.6±1.02ms        ? ?/sec   
 1.00    132.4±0.72ms        ? ?/sec
   > arrow_reader_clickbench/async/Q22    2.01    497.4±2.05ms        ? ?/sec   
 1.00    247.3±9.10ms        ? ?/sec
   > arrow_reader_clickbench/async/Q23    1.17    495.8±8.87ms        ? ?/sec   
 1.00    422.8±3.48ms        ? ?/sec
   > arrow_reader_clickbench/async/Q24    1.55     59.8±0.98ms        ? ?/sec   
 1.00     38.5±0.37ms        ? ?/sec
   > arrow_reader_clickbench/async/Q27    1.71    168.2±0.80ms        ? ?/sec   
 1.00     98.6±0.85ms        ? ?/sec
   > arrow_reader_clickbench/async/Q28    1.65    166.7±0.82ms        ? ?/sec   
 1.00    101.0±0.95ms        ? ?/sec
   > arrow_reader_clickbench/async/Q30    1.73     65.7±0.39ms        ? ?/sec   
 1.00     37.9±0.30ms        ? ?/sec
   > arrow_reader_clickbench/async/Q36    1.28    173.1±0.98ms        ? ?/sec   
 1.00    135.7±1.09ms        ? ?/sec
   > arrow_reader_clickbench/async/Q37    1.02    104.2±0.47ms        ? ?/sec   
 1.00    101.6±0.42ms        ? ?/sec
   > arrow_reader_clickbench/async/Q38    1.00     41.6±0.33ms        ? ?/sec   
 1.23     51.1±0.42ms        ? ?/sec
   > arrow_reader_clickbench/async/Q39    1.00     50.3±0.30ms        ? ?/sec   
 1.32     66.2±0.42ms        ? ?/sec
   > arrow_reader_clickbench/async/Q40    1.00     55.3±0.60ms        ? ?/sec   
 1.22     67.4±0.60ms        ? ?/sec
   > arrow_reader_clickbench/async/Q41    1.00     42.1±0.32ms        ? ?/sec   
 1.12     47.3±0.56ms        ? ?/sec
   > arrow_reader_clickbench/async/Q42    1.00     15.6±0.09ms        ? ?/sec   
 1.10     17.2±0.19ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q1      1.00      3.5±0.01ms        ? ?/sec   
 1.02      3.6±0.02ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q10     1.01     12.9±0.08ms        ? ?/sec   
 1.00     12.8±0.09ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q11     1.01     14.7±0.08ms        ? ?/sec   
 1.00     14.6±0.10ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q12     1.02     41.5±0.56ms        ? ?/sec   
 1.00     40.8±0.37ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q13     1.02     55.0±0.63ms        ? ?/sec   
 1.00     54.1±0.45ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q14     1.02     52.9±0.44ms        ? ?/sec   
 1.00     52.0±0.41ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q19     1.00      4.3±0.03ms        ? ?/sec   
 1.00      4.3±0.03ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q20     1.02    180.8±1.13ms        ? ?/sec   
 1.00    176.5±0.71ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q21     1.02    240.2±1.88ms        ? ?/sec   
 1.00    234.4±3.10ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q22     1.03    496.4±2.49ms        ? ?/sec   
 1.00    481.2±5.82ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q23     1.01   454.2±14.61ms        ? ?/sec   
 1.00   448.9±14.27ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q24     1.01     57.0±0.71ms        ? ?/sec   
 1.00     56.2±0.81ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q27     1.04    158.0±0.73ms        ? ?/sec   
 1.00    152.1±0.93ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q28     1.01    155.7±0.61ms        ? ?/sec   
 1.00    154.7±0.74ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q30     1.01     63.9±0.42ms        ? ?/sec   
 1.00     63.5±0.42ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q36     1.02    162.2±0.86ms        ? ?/sec   
 1.00    159.0±0.92ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q37     1.05     97.7±0.73ms        ? ?/sec   
 1.00     93.5±0.82ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q38     1.01     34.0±0.18ms        ? ?/sec   
 1.00     33.6±0.25ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q39     1.02     36.1±0.31ms        ? ?/sec   
 1.00     35.4±0.30ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q40     1.00     51.1±0.40ms        ? ?/sec   
 1.01     51.8±0.37ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q41     1.00     39.0±0.32ms        ? ?/sec   
 1.01     39.6±0.41ms        ? ?/sec
   > arrow_reader_clickbench/sync/Q42     1.00     14.8±0.15ms        ? ?/sec   
 1.01     15.0±0.09ms        ? ?/sec
   > ```
   
   Thank you @alamb  and the result is also reasonable
   
   Because, the result for me here is compared the Unified select PR with the 
main branch(And no parquet filter pushdown).
   
   https://github.com/apache/arrow-rs/pull/7454#issuecomment-2866308861
   
   So when we improve most of the regression for filter push down compared to 
no pushdown, it may also cause some regression to the original default push 
down, we can improve it further.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to