alamb commented on PR #7454: URL: https://github.com/apache/arrow-rs/pull/7454#issuecomment-2867836085
Testing this PR using my benchmark in - https://github.com/apache/arrow-rs/pull/7470 Shows measureable improvements. The only thing that looks like it may be slower is Q1 which is roughly what you observed as well ``` error: bench failed, to rerun pass `-p parquet --bench arrow_reader_clickbench` group main unified_select ----- ---- -------------- arrow_reader_clickbench/sync/Q1 1.00 3.0±0.01ms ? ?/sec 1.19 3.6±0.02ms ? ?/sec arrow_reader_clickbench/sync/Q10 1.09 13.9±0.14ms ? ?/sec 1.00 12.7±0.08ms ? ?/sec arrow_reader_clickbench/sync/Q11 1.07 15.6±0.12ms ? ?/sec 1.00 14.6±0.09ms ? ?/sec arrow_reader_clickbench/sync/Q12 1.04 41.9±0.34ms ? ?/sec 1.00 40.5±0.41ms ? ?/sec arrow_reader_clickbench/sync/Q13 1.03 55.2±0.42ms ? ?/sec 1.00 53.5±0.47ms ? ?/sec arrow_reader_clickbench/sync/Q14 1.05 53.8±0.49ms ? ?/sec 1.00 51.2±0.96ms ? ?/sec arrow_reader_clickbench/sync/Q19 1.00 4.3±0.02ms ? ?/sec 1.00 4.3±0.02ms ? ?/sec arrow_reader_clickbench/sync/Q20 1.03 181.2±0.71ms ? ?/sec 1.00 176.4±0.61ms ? ?/sec arrow_reader_clickbench/sync/Q21 1.04 240.3±1.20ms ? ?/sec 1.00 231.2±1.08ms ? ?/sec arrow_reader_clickbench/sync/Q22 1.04 497.4±2.89ms ? ?/sec 1.00 476.8±4.11ms ? ?/sec arrow_reader_clickbench/sync/Q23 1.04 458.3±13.13ms ? ?/sec 1.00 441.3±13.66ms ? ?/sec arrow_reader_clickbench/sync/Q24 1.05 57.0±0.68ms ? ?/sec 1.00 54.2±0.65ms ? ?/sec arrow_reader_clickbench/sync/Q27 1.03 158.2±0.81ms ? ?/sec 1.00 153.2±1.04ms ? ?/sec arrow_reader_clickbench/sync/Q28 1.00 155.3±0.86ms ? ?/sec 1.00 154.6±0.84ms ? ?/sec arrow_reader_clickbench/sync/Q30 1.00 63.7±0.41ms ? ?/sec 1.00 63.5±0.46ms ? ?/sec arrow_reader_clickbench/sync/Q36 1.01 160.7±1.03ms ? ?/sec 1.00 159.2±1.02ms ? ?/sec arrow_reader_clickbench/sync/Q37 1.02 95.9±0.71ms ? ?/sec 1.00 93.6±0.67ms ? ?/sec ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
