kou commented on code in PR #46399: URL: https://github.com/apache/arrow/pull/46399#discussion_r2083679146
########## c_glib/arrow-glib/basic-data-type.cpp: ########## @@ -2366,6 +2366,21 @@ garrow_fixed_shape_tensor_data_type_get_shape(GArrowFixedShapeTensorDataType *da return arrow_shape.data(); } +/** + * garrow_fixed_shape_tensor_data_type_get_ndim: Review Comment: Could you implement this as a property because this is not a complex type such as an array? Could you use `n_dims` or `n_dimensions` instead of `ndim`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
