kou commented on code in PR #46399:
URL: https://github.com/apache/arrow/pull/46399#discussion_r2094886844
##########
c_glib/arrow-glib/basic-data-type.cpp:
##########
@@ -2282,6 +2307,19 @@
garrow_fixed_shape_tensor_data_type_init(GArrowFixedShapeTensorDataType *object)
static void
garrow_fixed_shape_tensor_data_type_class_init(GArrowFixedShapeTensorDataTypeClass
*klass)
{
+ GParamSpec *spec;
+
+ auto gobject_class = G_OBJECT_CLASS(klass);
+ gobject_class->get_property =
garrow_fixed_shape_tensor_data_type_get_property;
+
+ spec = g_param_spec_uint64("n_dimensions",
Review Comment:
Could you add a docstring for public properties?
```suggestion
/**
* GArrowFixedShapeTensorDataType::n-dimensions:
*
* The number of dimensions of tensor elements.
*
* Since: 21.0.0
*/
spec = g_param_spec_uint64("n_dimensions",
```
##########
c_glib/arrow-glib/basic-data-type.cpp:
##########
@@ -2282,6 +2307,19 @@
garrow_fixed_shape_tensor_data_type_init(GArrowFixedShapeTensorDataType *object)
static void
garrow_fixed_shape_tensor_data_type_class_init(GArrowFixedShapeTensorDataTypeClass
*klass)
{
+ GParamSpec *spec;
+
+ auto gobject_class = G_OBJECT_CLASS(klass);
+ gobject_class->get_property =
garrow_fixed_shape_tensor_data_type_get_property;
+
+ spec = g_param_spec_uint64("n_dimensions",
+ "NDimensions",
Review Comment:
```suggestion
"N dimensions",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
