kou commented on issue #46436:
URL: https://github.com/apache/arrow/issues/46436#issuecomment-2889455426
My opinion:
* Add `arrow::EqualOptions::floating_approximate` or something
* Use `arrow::ArrayStatistics::Equals()` not
`arrow::ArrayStatistics::ApproximateEquals()` for approximate equal too
`arrow::Array::ApproximateEquals()` was introduced by #219 and
`arrow::EqualOptions` was introduced by #4005 . I feel that if we have
`arrow::EqualOptions` when we added `arrow::Array::ApproximateEquals()`, we
didn't add `arrow::Array::Equals()`.
@pitrou @bkietz @zanmato1984 @wgtmac @lidavidm Do you have any opinion for
`arrow::Array{,Statistics}::{,Aproximate}Equals()` API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
