andishgar commented on issue #46436: URL: https://github.com/apache/arrow/issues/46436#issuecomment-2891520080
> I think using EqualOptions is preferable (e.g. you can specify tolerance, NaN behavior, etc.) @lidavidm Thanks for sharing your opinion! Just a quick note: both `Equals` and `ApproximateEquals` accept `EqualOptions`. The main question is whether we should use `ApproximateEquals` or `Equals` for the following lines. (For reference, `ApproximateEquals` is currently used in the C++ implementation of `arrow::Array` for similar scenarios.) https://github.com/apache/arrow/blob/afb535b7045ebdfdde1ba2fbb420ac3527a03f89/cpp/src/arrow/array/statistics.cc#L33-L35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
