ianmcook commented on a change in pull request #9907:
URL: https://github.com/apache/arrow/pull/9907#discussion_r607888261
##########
File path: r/tests/testthat/test-compute-aggregate.R
##########
@@ -267,6 +260,20 @@ test_that("quantile and median NAs, edge cases, and
exceptions", {
)
})
+test_that("median passes ... args to quantile", {
+ skip_if(
+ !"..." %in% names(formals(median)),
+ "The median generic lacks dots in R 3.3.0 and earlier"
+ )
Review comment:
In ARROW-11338, I assumed the `median()` generic always had dots args,
but apparently it didn't in R 3.3.0 and earlier.
I'm surprised that `R CMD check` did not detect S3 generic/method
consistency problems in R 3.3.0, but it did not:
https://github.com/ursacomputing/crossbow/runs/2275559899#step:7:193
Given that, it's cleaner to skip the tests that use the `median()` dots args
than it would be to conditionally define `median.ArrowDatum` with/without dots
depending on whether the generic has them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
