nealrichardson commented on a change in pull request #9907:
URL: https://github.com/apache/arrow/pull/9907#discussion_r607895583
##########
File path: r/tests/testthat/test-dplyr-string-functions.R
##########
@@ -18,6 +18,27 @@
library(dplyr)
library(stringr)
+test_that("sub and gsub with ignore.case = FALSE and fixed = TRUE", {
+ df <- tibble(x = c("Foo", "bar"))
Review comment:
Do these tests require skip_if_not_available("utf8proc")?
##########
File path: r/tests/testthat/test-dplyr-string-functions.R
##########
@@ -18,6 +18,27 @@
library(dplyr)
library(stringr)
+test_that("sub and gsub with ignore.case = FALSE and fixed = TRUE", {
+ df <- tibble(x = c("Foo", "bar"))
+
+ expect_dplyr_equal(
+ input %>%
+ transmute(x = sub("Foo", "baz", x, fixed = TRUE)) %>%
+ collect(),
+ df
+ )
+ expect_dplyr_equal(
+ input %>%
+ transmute(x = gub("o", "u", x, fixed = TRUE)) %>%
Review comment:
```suggestion
transmute(x = gsub("o", "u", x, fixed = TRUE)) %>%
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
