hiroyuki-sato commented on code in PR #46527:
URL: https://github.com/apache/arrow/pull/46527#discussion_r2099253795
##########
ci/scripts/python_wheel_unix_test.sh:
##########
@@ -59,7 +59,7 @@ export
PARQUET_TEST_DATA=${source_dir}/cpp/submodules/parquet-testing/data
if [ "${INSTALL_PYARROW}" == "ON" ]; then
# Install the built wheels
- python -m pip install ${source_dir}/python/repaired_wheels/*.whl
+ python -m pip install "${source_dir}"/python/repaired_wheels/*.whl
Review Comment:
I quoted whole string like `{arrow_dir}/ci/scripts/rust_build.sh"` at first.
But, In this case `*.whl` part can't quote. So,
* `"${source_dir}"/python/repaired_wheels/*.whl`
* `"${source_dir}/python/repaired_wheels/"*.whl`
Which is better, what do you think @kou ?
I think `"${source_dir}"` is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
