hiroyuki-sato commented on code in PR #46527:
URL: https://github.com/apache/arrow/pull/46527#discussion_r2099393759
##########
ci/scripts/python_wheel_unix_test.sh:
##########
@@ -59,7 +59,7 @@ export
PARQUET_TEST_DATA=${source_dir}/cpp/submodules/parquet-testing/data
if [ "${INSTALL_PYARROW}" == "ON" ]; then
# Install the built wheels
- python -m pip install ${source_dir}/python/repaired_wheels/*.whl
+ python -m pip install "${source_dir}"/python/repaired_wheels/*.whl
Review Comment:
Thanks.
# Quoting policy
Which plan is better? I think `${source_dir}"/python/repaired_wheels/*.whl`
is rare,
So plan1 is better. what do you think?
## plan1
* Rule1: Basically, quote whole string
* `"${source_dir}/python/repaired_wheels"`
* Rule2: If string contaings glob (like `*`), quote variable only.
* `python -m pip install "${source_dir}"/python/repaired_wheels/*.whl`
## plan2
* Rule1: quote variable only.
* `"${source_dir}"/python/repaired_wheels`
* `python -m pip install "${source_dir}"/python/repaired_wheels/*.whl`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
