kou commented on code in PR #46261: URL: https://github.com/apache/arrow/pull/46261#discussion_r2103620418
########## c_glib/arrow-glib/compute.cpp: ########## @@ -37,6 +37,9 @@ #include <arrow/acero/exec_plan.h> #include <arrow/acero/options.h> +// Initialize the compute library and register compute kernels. +auto compute_init_status_ = arrow::compute::Initialize(); Review Comment: If we need to check the status, we must add an initialization function (something like `gboolean garrow_compute_initialize(GError **error)`) and users call it explicitly. BTW, is there possibility that `arrow::compute::Initialize()` is failed? If `arrow::compute::Initialize()` is never failed, we don't need to check the status and we may use different return type than `arrow::Status`. ########## c_glib/arrow-glib/compute.cpp: ########## @@ -37,6 +37,9 @@ #include <arrow/acero/exec_plan.h> #include <arrow/acero/options.h> +// Initialize the compute library and register compute kernels. +auto compute_init_status_ = arrow::compute::Initialize(); Review Comment: If we need to check the status, we must add an initialization function (something like `gboolean garrow_compute_initialize(GError **error)`) and users call it explicitly. BTW, is there possibility that `arrow::compute::Initialize()` is failed? If `arrow::compute::Initialize()` is never failed, we don't need to check the status and we may want to use different return type than `arrow::Status`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
