raulcd commented on code in PR #46261:
URL: https://github.com/apache/arrow/pull/46261#discussion_r2105175172


##########
c_glib/arrow-glib/compute.cpp:
##########
@@ -37,6 +37,9 @@
 #include <arrow/acero/exec_plan.h>
 #include <arrow/acero/options.h>
 
+// Initialize the compute library and register compute kernels.
+auto compute_init_status_ = arrow::compute::Initialize();

Review Comment:
   Thanks @pitrou , I've reverted the previous commit.
   @kou I've pushed the following c_glib change:
   ```c
   // Initialize the compute library and register compute kernels.
   static auto compute_init_status_ = arrow::compute::Initialize();
   
   gboolean
   garrow_compute_is_initialized(GError **error)
   {
     if (!compute_init_status_.ok()) {
       g_set_error(error,
                   GARROW_ERROR,
                   GARROW_ERROR_UNKNOWN,
                   "Arrow compute module is not properly initialized: %s",
                   compute_init_status_.ToString().c_str());
     }
     return compute_init_status_.ok();
   }
   ```
   I can update this to a function to make the explicit call to Initialize but 
I am not sure how can I make our Ruby implementation do the call implicitly? do 
we have some initialization already? 
   
   Or could be enough providing a function to users so they can check the 
status of the initialization? as the last commit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to