pitrou commented on code in PR #46532:
URL: https://github.com/apache/arrow/pull/46532#discussion_r2108323284
##########
cpp/src/parquet/arrow/schema.cc:
##########
@@ -1033,11 +1035,11 @@ Result<bool> ApplyOriginalStorageMetadata(const Field&
origin_field,
modified = true;
}
- if ((origin_type->id() == ::arrow::Type::LARGE_BINARY &&
- inferred_type->id() == ::arrow::Type::BINARY) ||
- (origin_type->id() == ::arrow::Type::LARGE_STRING &&
- inferred_type->id() == ::arrow::Type::STRING)) {
- // Read back binary-like arrays with the intended offset width.
+ if ((::arrow::is_binary_or_binary_view(origin_type->id()) &&
+ ::arrow::is_binary_or_binary_view(inferred_type->id())) ||
+ (::arrow::is_string_or_string_view(origin_type->id()) &&
+ ::arrow::is_string_or_string_view(inferred_type->id()))) {
+ // Read back binary-like arrays with the intended layout (narrow, large,
view).
Review Comment:
I don't know. We usually don't give them a name, and I could say "regular"
or "normal" instead :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
