pitrou commented on code in PR #46532:
URL: https://github.com/apache/arrow/pull/46532#discussion_r2108327356
##########
cpp/src/parquet/encoder.cc:
##########
@@ -1304,11 +1326,15 @@ class DeltaLengthByteArrayEncoder : public EncoderImpl,
};
void DeltaLengthByteArrayEncoder::Put(const ::arrow::Array& values) {
- AssertBaseBinary(values);
+ AssertVarLengthBinary(values);
if (::arrow::is_binary_like(values.type_id())) {
PutBinaryArray(checked_cast<const ::arrow::BinaryArray&>(values));
- } else {
+ } else if (::arrow::is_large_binary_like(values.type_id())) {
PutBinaryArray(checked_cast<const ::arrow::LargeBinaryArray&>(values));
+ } else if (::arrow::is_binary_view_like(values.type_id())) {
+ PutBinaryArray(checked_cast<const ::arrow::BinaryViewArray&>(values));
+ } else {
+ throw ParquetException("Only binary-like data supported");
Review Comment:
Yes, we can add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
