domoritz commented on a change in pull request #8418:
URL: https://github.com/apache/arrow/pull/8418#discussion_r608350657
##########
File path: js/src/util/utf8.ts
##########
@@ -22,7 +22,7 @@ import {
} from 'text-encoding-utf-8';
/** @ignore @suppress {missingRequire} */
-const _Buffer = typeof Buffer === 'function' ? Buffer : null;
+const _Buffer = eval("typeof Buffer === 'function' ? Buffer : null");
Review comment:
This will cause problems in environments with a CSP that does not allow
eval, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
