domoritz commented on a change in pull request #8418:
URL: https://github.com/apache/arrow/pull/8418#discussion_r608770963



##########
File path: js/src/util/utf8.ts
##########
@@ -22,7 +22,7 @@ import {
 } from 'text-encoding-utf-8';
 
 /** @ignore @suppress {missingRequire} */
-const _Buffer = typeof Buffer === 'function' ? Buffer : null;
+const _Buffer = eval("typeof Buffer === 'function' ? Buffer : null");

Review comment:
       It would be good to try. Maybe it's okay if the function constructor 
never gets called. 
   
   I'm Vega, we added an ast evaluator in addition to a function constructor to 
support expressions in environments with CSP. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to