kou commented on code in PR #128: URL: https://github.com/apache/arrow-js/pull/128#discussion_r2111032992
########## src/io/adapters.ts: ########## @@ -96,7 +96,8 @@ function* fromIterable<T extends ArrayBufferViewInput>(source: Iterable<T> | T): } } while (!done); } catch (e) { - (threw = true) && (typeof it.throw === 'function') && (it.throw(e)); + threw = true; + (typeof it.throw === 'function') && (it.throw(e)); Review Comment: This fixes ```99:10 error Unexpected constant truthiness on the left-hand side of a `&&` expression no-constant-binary-expression```. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org