kou commented on code in PR #128:
URL: https://github.com/apache/arrow-js/pull/128#discussion_r2111034730
##########
src/io/whatwg/iterable.ts:
##########
@@ -43,7 +43,7 @@ function iterableAsReadableDOMStream<T>(source: Iterable<T>,
options?: ReadableD
...options as any,
start(controller) { next(controller, it || (it =
source[Symbol.iterator]() as SourceIterator<T>)); },
pull(controller) { it ? (next(controller, it)) : controller.close(); },
- cancel() { (it?.return && it.return() || true) && (it = null); }
+ cancel() { (it?.return && it.return()); it = null; }
Review Comment:
This fixes ```46:21 error Unexpected constant truthiness on the left-hand
side of a `&&` expression no-constant-binary-expression```.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
