davidhcoe commented on code in PR #2889: URL: https://github.com/apache/arrow-adbc/pull/2889#discussion_r2112118824
########## go/adbc/version.go: ########## @@ -0,0 +1,20 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package adbc + +const DriverVersion = "1.7.0" Review Comment: @zeroshade - I am assuming this is the most controversial part of this PR. We track the PREVIOUS_VERSION_NATIVE and increment that when the releases happen, but we don't have anything to indicate the current version. Here I am following the pattern established by the dependency DLLs, but if you have thoughts on better ways to do this, I am all ears. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
