zeroshade commented on PR #2889: URL: https://github.com/apache/arrow-adbc/pull/2889#issuecomment-2931983843
Sorry for the delay here, i played with this a bit. It looks like the internal build info doesn't seem to pick up the tags for the non-root module tag. If I add a local tag of `v1.6.0` then the build info picks up properly and gives a version of `v1.6.0+dirty`. Otherwise you get a pseudo-version of `v0.0.0-<current commit date>-<commit sha>+dirty`. In both cases, it should be easy enough to update the local variable to use debug.BuildInfo to get the version, so the question is going to be a matter of updating the build scripts to get it to pick up the version. (Looks like it'll only embed the subdirectory version when using `go install` or `go get`, neither of which works for building a shared object library. Updating the build script to set the tag before building is still probably better than needing an internal var to update the version etc. Do you want me to update this PR? Or poke it yourself? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
