zanmato1984 commented on code in PR #46566:
URL: https://github.com/apache/arrow/pull/46566#discussion_r2115110646
##########
python/pyarrow/_acero.pyx:
##########
@@ -273,14 +273,15 @@ cdef class _HashJoinNodeOptions(ExecNodeOptions):
def _set_options(
self, join_type, left_keys, right_keys, left_output=None,
right_output=None,
- output_suffix_for_left="", output_suffix_for_right="",
+ output_suffix_for_left="", output_suffix_for_right="", Expression
filter_expression=None,
Review Comment:
I think we can simply call it (and other places passing through this
parameter) `filter` (which also matches C++'s naming).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
