xingyu-long commented on code in PR #46566:
URL: https://github.com/apache/arrow/pull/46566#discussion_r2115199593


##########
python/pyarrow/acero.py:
##########
@@ -114,6 +114,8 @@ def _perform_join(join_type, left_operand, left_keys,
         in the join result.
     output_type: Table or InMemoryDataset
         The output type for the exec plan result.
+    filter_expression: Expression
+        Expression that will be used during join operation.

Review Comment:
   Done



##########
python/pyarrow/tests/test_acero.py:
##########
@@ -300,6 +300,37 @@ def test_order_by():
         _ = OrderByNodeOptions([("b", "ascending")], null_placement="start")
 
 
+def test_hash_join_with_filter():

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to