tustvold commented on code in PR #389:
URL:
https://github.com/apache/arrow-rs-object-store/pull/389#discussion_r2115996113
##########
src/local.rs:
##########
@@ -641,6 +641,7 @@ impl LocalFileSystem {
let walkdir = WalkDir::new(root_path)
// Don't include the root directory itself
.min_depth(1)
+ .sort_by_file_name()
Review Comment:
This will list every file in the directory, sort it, and then return it - at
the very least this should be explicitly opt-in as directories can get very
large - the standard library APIs are intentionally lazy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
