timwaizenegger commented on code in PR #389:
URL:
https://github.com/apache/arrow-rs-object-store/pull/389#discussion_r2116042705
##########
src/local.rs:
##########
@@ -641,6 +641,7 @@ impl LocalFileSystem {
let walkdir = WalkDir::new(root_path)
// Don't include the root directory itself
.min_depth(1)
+ .sort_by_file_name()
Review Comment:
That's true and you don't always need it. But sometimes you absolutely do;
offset listing just makes no sense without sorting.
- offset listing: need sorting
- iterator listing: don't care about sorting, higher perf. without sorting
opt-out could be a good option too given those requirements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
