emkornfield commented on a change in pull request #9750:
URL: https://github.com/apache/arrow/pull/9750#discussion_r608789105
##########
File path: cpp/src/gandiva/gdv_function_stubs_test.cc
##########
@@ -160,4 +160,118 @@ TEST(TestGdvFnStubs, TestCastFloat8) {
ctx.Reset();
}
+ TEST(TestGdvFnStubs, TestToCharFromInt32) {
+ gandiva::ExecutionContext ctx;
+ uint64_t ctx_ptr = reinterpret_cast<int64_t>(&ctx);
+ int32_t out_len = 0;
+
+ const char* out_str = gdv_fn_to_char_int32_int64(ctx_ptr, -46, 100,
"%1", &out_len);
Review comment:
Can you check some other examples for format. I'm not sure the library
that is being used uses the same specification for format strings a SQL to_char
would.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
