lidavidm commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125251334
##########
c/vendor/toml++/toml.hpp:
##########
Review Comment:
We need to update LICENSE/NOTICE and .gitattributes
##########
c/include/arrow-adbc/adbc_driver_manager.h:
##########
@@ -31,6 +31,16 @@ extern "C" {
#ifndef ADBC_DRIVER_MANAGER_H
#define ADBC_DRIVER_MANAGER_H
+enum LoadOptions {
Review Comment:
I presume it's `enum` over `enum class` to maintain C compat? We use
`#define` for all constants so far so can we be consistent?
##########
c/driver_manager/CMakeLists.txt:
##########
@@ -15,6 +15,7 @@
# specific language governing permissions and limitations
# under the License.
+include(FetchContent)
Review Comment:
Where is this used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
