zeroshade commented on code in PR #2918: URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125294489
########## c/driver_manager/adbc_driver_manager.cc: ########## @@ -15,26 +15,41 @@ // specific language governing permissions and limitations // under the License. -#include "arrow-adbc/adbc_driver_manager.h" +#if defined(_WIN32) +#pragma comment(lib, "advapi32.lib") // for registry stuff +#include <windows.h> // Must come first + +#include <libloaderapi.h> +#include <string.h> // strncasecmp +#include <strsafe.h> + +#ifdef _MSC_VER +#define strncasecmp _strnicmp +#endif // _MSC_VER + +#else +#include <dlfcn.h> +#endif // defined(_WIN32) + +#include <toml++/toml.hpp> #include "arrow-adbc/adbc.h" +#include "arrow-adbc/adbc_driver_manager.h" #include <algorithm> #include <array> #include <cctype> #include <cerrno> #include <cstring> +#include <filesystem> // NOLINT [build/c++17] #include <string> #include <unordered_map> #include <utility> +#include <vector> -#if defined(_WIN32) -#include <windows.h> // Must come first +using namespace std::string_literals; // NOLINT [build/namespaces] -#include <libloaderapi.h> -#include <strsafe.h> -#else -#include <dlfcn.h> -#endif // defined(_WIN32) +ADBC_EXPORT +std::vector<std::filesystem::path> AdbcParsePath(const std::string_view& path); Review Comment: Ah, must have missed that. Why doesn't the other internal function use that too then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
