lidavidm commented on PR #2917: URL: https://github.com/apache/arrow-adbc/pull/2917#issuecomment-2942734201
So again, this is why I keep asking if the option should really be a boolean :) Since the new option is only effective when we are asking for nanoseconds, it's effectively 3 possible states modeled with 4 possible configurations. Either we should always be checking for overflow regardless of the type or we should have a single option for nanoseconds, nanoseconds (but error on overflow), or microseconds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
