davidhcoe commented on PR #2917: URL: https://github.com/apache/arrow-adbc/pull/2917#issuecomment-2942749437
> So again, this is why I keep asking if the option should really be a boolean :) > > Since the new option is only effective when we are asking for nanoseconds, it's effectively 3 possible states modeled with 4 possible configurations. Either we should always be checking for overflow regardless of the type or we should have a single option for nanoseconds, nanoseconds (but error on overflow), or microseconds. Overflow only applies to large date ranges (before year 1677 or after 2262) that use nanoseconds. The native Go behavior is to just overflow to the wrong value (which is weird, tbh) so the only options are: 1.) Leave things alone 2.) Strictly enforce the integrity of the data and throw an error when the overflow _will_ happen 3.) Use microseconds to avoid 1 and 2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
