CurtHagenlocher commented on code in PR #2921:
URL: https://github.com/apache/arrow-adbc/pull/2921#discussion_r2132929801
##########
csharp/src/Drivers/Databricks/DatabricksConnection.cs:
##########
@@ -165,9 +165,16 @@ private void ValidateProperties()
// Parse default namespace
string? defaultCatalog = null;
string? defaultSchema = null;
- Properties.TryGetValue(AdbcOptions.Connection.CurrentCatalog, out
defaultCatalog);
+ // only if enableMultipleCatalogSupport is true, do we supply
catalog from connection properties
+ if (_enableMultipleCatalogSupport)
+ {
+ Properties.TryGetValue(AdbcOptions.Connection.CurrentCatalog,
out defaultCatalog);
+ }
Properties.TryGetValue(AdbcOptions.Connection.CurrentDbSchema, out
defaultSchema);
+ // SPARK is a special catalog name - rely on server to return a
default catalog if there is one
+ defaultCatalog = HandleSparkCatalog(defaultCatalog);
Review Comment:
I don't understand this question-and-answer. Someone can pass SPARK as the
initial catalog but then it gets ignored? And this is the correct behavior?
##########
csharp/src/Drivers/Databricks/DatabricksConnection.cs:
##########
@@ -574,5 +581,14 @@ protected override void ValidateOAuthParameters()
base.ValidateOAuthParameters();
}
}
+
+ internal static String? HandleSparkCatalog(String? CatalogName)
Review Comment:
```suggestion
internal static string? HandleSparkCatalog(string? catalogName)
```
That is, use the type alias `string` instead of the type name `String` and
use a lower-case argument name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
