toddmeng-db commented on code in PR #2921:
URL: https://github.com/apache/arrow-adbc/pull/2921#discussion_r2132971569
##########
csharp/src/Drivers/Databricks/DatabricksConnection.cs:
##########
@@ -165,9 +165,16 @@ private void ValidateProperties()
// Parse default namespace
string? defaultCatalog = null;
string? defaultSchema = null;
- Properties.TryGetValue(AdbcOptions.Connection.CurrentCatalog, out
defaultCatalog);
+ // only if enableMultipleCatalogSupport is true, do we supply
catalog from connection properties
+ if (_enableMultipleCatalogSupport)
+ {
+ Properties.TryGetValue(AdbcOptions.Connection.CurrentCatalog,
out defaultCatalog);
+ }
Properties.TryGetValue(AdbcOptions.Connection.CurrentDbSchema, out
defaultSchema);
+ // SPARK is a special catalog name - rely on server to return a
default catalog if there is one
+ defaultCatalog = HandleSparkCatalog(defaultCatalog);
Review Comment:
This maintains backward compatibility with older workspaces, where the Hive
metastore was accessed via the `spark` catalog name.
In newer DBR versions with Unity Catalog, the default catalog is typically
`hive_metastore`.
Passing `null` here allows the runtime to fall back to the workspace-defined
default catalog for the session.
Let me add a comment to be clearer. Does the above make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
