amoeba commented on code in PR #46286:
URL: https://github.com/apache/arrow/pull/46286#discussion_r2133170752
##########
cpp/src/arrow/compute/kernels/vector_run_end_encode_test.cc:
##########
@@ -369,6 +369,12 @@ std::vector<REETestData> GenerateTestData() {
REETestData::JSON(time64(TimeUnit::MICRO), "[1, 1, 0, 5, 5, 5, 255,
255]",
"[1, 0, 5, 255]", "[2, 3, 6, 8]"),
// Decimal and fixed size binary types
+ REETestData::JSON(decimal32(4, 1),
+ R"(["1.0", "1.0", "0.0", "5.2", "5.2", "5.2", "255.0",
"255.0"])",
+ R"(["1.0", "0.0", "5.2", "255.0"])", "[2, 3, 6, 8]"),
+ REETestData::JSON(decimal64(4, 1),
+ R"(["1.0", "1.0", "0.0", "5.2", "5.2", "5.2", "255.0",
"255.0"])",
+ R"(["1.0", "0.0", "5.2", "255.0"])", "[2, 3, 6, 8]"),
Review Comment:
Good catch. Added in 3270505b3255f126255bfdcda473de5357dc9dd4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]