pitrou commented on code in PR #46286:
URL: https://github.com/apache/arrow/pull/46286#discussion_r2137044012
##########
cpp/src/arrow/compute/kernels/vector_run_end_encode.cc:
##########
@@ -508,6 +509,10 @@ static ArrayKernelExec GenerateREEKernelExec(Type::type
type_id) {
return Functor::template Exec<UInt64Type>;
case Type::INTERVAL_MONTH_DAY_NANO:
return Functor::template Exec<MonthDayNanoIntervalType>;
+ case Type::DECIMAL32:
+ return Functor::template Exec<Decimal32Type>;
+ case Type::DECIMAL64:
+ return Functor::template Exec<Decimal64Type>;
Review Comment:
I'm curious, do we have to instantiate `Exec` for these additional types? Or
can we reuse `Exec<UInt32Type>` and `Exec<UInt64Type>` respectively? That would
reduce the amount of code generated for these kernels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
