IndifferentArea commented on code in PR #46730:
URL: https://github.com/apache/arrow/pull/46730#discussion_r2133442265
##########
cpp/src/arrow/array/builder_binary.h:
##########
@@ -645,6 +657,28 @@ class ARROW_EXPORT BinaryViewBuilder : public ArrayBuilder
{
UnsafeAppend(value.data(), static_cast<int64_t>(value.size()));
}
+ Result<std::pair<int32_t, int32_t>> AppendBlock(const uint8_t* value,
+ const int64_t length);
+
+ Result<std::pair<int32_t, int32_t>> AppendBlock(const char* value,
+ const int64_t length) {
+ return AppendBlock(reinterpret_cast<const uint8_t*>(value), length);
+ }
+
+ Result<std::pair<int32_t, int32_t>> AppendBlock(const std::string& value) {
+ return AppendBlock(value.data(), static_cast<int64_t>(value.size()));
+ }
+
+ Status AppendViewFromBuffer(int32_t buffer_id, int32_t buffer_offset,
int32_t start,
Review Comment:
sorry for this annoying inconsistency. To be clear, is one of `block` or
`buffer` prefered, or either is fine? I found `block` is used in
`StringHeapBuilder` while `buffer` is used in `BinaryBuilder`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
