IndifferentArea commented on code in PR #46730:
URL: https://github.com/apache/arrow/pull/46730#discussion_r2133457449
##########
cpp/src/arrow/array/builder_binary.h:
##########
@@ -645,6 +657,28 @@ class ARROW_EXPORT BinaryViewBuilder : public ArrayBuilder
{
UnsafeAppend(value.data(), static_cast<int64_t>(value.size()));
}
+ Result<std::pair<int32_t, int32_t>> AppendBlock(const uint8_t* value,
Review Comment:
can i directly use `BinaryViewType` since it already contains these two info
we need?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
