khwilson commented on code in PR #44184:
URL: https://github.com/apache/arrow/pull/44184#discussion_r2137679315
##########
cpp/src/arrow/compute/kernels/hash_aggregate_numeric.cc:
##########
@@ -259,8 +271,11 @@ struct GroupedReducingFactory {
// Sum implementation
template <typename Type>
-struct GroupedSumImpl : public GroupedReducingAggregator<Type,
GroupedSumImpl<Type>> {
- using Base = GroupedReducingAggregator<Type, GroupedSumImpl<Type>>;
+struct GroupedSumImpl
+ : public GroupedReducingAggregator<Type, GroupedSumImpl<Type>,
+ typename
FindAccumulatorType<Type>::Type> {
Review Comment:
Oh, good catch. Initially it was because I had added the `PromoteDecimal` as
a template argument, which necessitated spelling out all the arguments. Can
remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
