khwilson commented on code in PR #44184:
URL: https://github.com/apache/arrow/pull/44184#discussion_r2137664477
##########
python/pyarrow/tests/test_compute.py:
##########
@@ -355,10 +355,55 @@ def test_sum_array(arrow_type):
arr = pa.array([], type=arrow_type)
assert arr.sum().as_py() is None # noqa: E711
+ assert pc.sum(arr).as_py() is None # noqa: E711
Review Comment:
Sure, but as it was, this test tested both `arr.sum()` and `pc.sum(arr)` for
each of its subcases _except_ this one. The correct change would be to remove
all those checks, which seemed like a larger change than making it consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
