alamb commented on code in PR #7663:
URL: https://github.com/apache/arrow-rs/pull/7663#discussion_r2145415638
##########
parquet-variant/src/variant.rs:
##########
@@ -303,7 +303,7 @@ impl<'m> VariantMetadata<'m> {
#[derive(Clone, Copy, Debug, PartialEq)]
pub struct VariantObject<'m, 'v> {
- pub metadata: &'m VariantMetadata<'m>,
+ pub metadata: VariantMetadata<'m>,
Review Comment:
This is the core difference -- rather than having a reference to a
`VariantMetadata` Objects and Arrays now have the objects inlined (and the
objects themselves have references to the underlying `&[u8]`)
Note that VariantMetadata is a pointer and a few `usize` so I think it is
better to inline them anyways rather than have an extra layer of indirection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
