scovich commented on code in PR #7663:
URL: https://github.com/apache/arrow-rs/pull/7663#discussion_r2146950011
##########
parquet-variant/src/variant.rs:
##########
@@ -303,7 +303,7 @@ impl<'m> VariantMetadata<'m> {
#[derive(Clone, Copy, Debug, PartialEq)]
pub struct VariantObject<'m, 'v> {
- pub metadata: &'m VariantMetadata<'m>,
+ pub metadata: VariantMetadata<'m>,
Review Comment:
One fat pointer, two usize, and a `VariantMetadataHeader` that should easily
pack to one usize. So 40B instead of 16B. That does seem within the range of
"probably doesn't matter" when it comes to memory consumption. And this avoids
a double pointer indirection when accessing the metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
